This repository was archived by the owner on Jul 21, 2023. It is now read-only.
browser fix - pre-load files with brfs#17
Closed
kumavis wants to merge 1 commit intolibp2p:masterfrom
Closed
Conversation
Author
|
this fix is also required for browserify support: #16 |
Member
|
#12 removes the use of |
Author
|
I'll wait 👍 |
wemeetagain
pushed a commit
to ChainSafe/js-libp2p-crypto
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are loading a file via
fshere https://github.com/libp2p/js-libp2p-crypto/blob/master/src/index.js#L6This breaks support for module consumers using browserify. The brfs module fixes this. The flag in the
package.jsonindicates that this module requires pre-processing via the local brfs dependency to be imported correctly.